Redesigned configuration handling#264
Open
Snapex2409 wants to merge 6 commits into
Open
Conversation
IshaanDesai
approved these changes
May 20, 2026
Member
IshaanDesai
left a comment
There was a problem hiding this comment.
The proposed change to the configuration module makes a lot of sense. I just have a few questions before merging this.
2ad4cff to
373e665
Compare
Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>
Member
|
Ready to squash and merge. Please add a changelog, as this is a significant change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implementation should simplify future changes to configuration entries.
Error handling was shifted towards special loading contexts.
The core concepts are:
@config_entryConfigDSL, which provides the methodsget_or_none,get_with_defaultandget_or_raise. These methods can accept default args and format strings for success or failure.Checklist:
CHANGELOG.md.